[TuxOnIce-devel] Have some (garbled) crash info for ToI 3.2 and 2.6.39.4

[Kenneth R. Crudup]

On Wed, 14 Sep 2011, Kenneth R. Crudup wrote:

>> [  351.712054] ------------[ cut here ]------------
>> [  351.712065] kernel BUG at block/blk-core.c:1644!

So, I looked there; changing that from a BUG_ON() to a WARN_ON() seems
to have stopped it from crashing during the suspend phase (which leads
to the never-ending "Cleaning up" on resume.

"git blame" shows that the line comes from commit db7d3f29, and it used
to look like this:

diff --cc block/blk-core.c
index b485de4,ee1a1e7..3c97b54
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@@ -1582,9 -1598,6 +1601,9 @@@ void submit_bio(int rw, struct bio *bio

        bio->bi_rw |= rw;

 +      if (unlikely(trap_non_toi_io))
-               BUG_ON(!bio_rw_flagged(bio, BIO_RW_TUXONICE));
++              BUG_ON(!(bio->bi_rw & REQ_TOI));
 +
        /*
         * If it's a regular read/write or a barrier with data attached,
         * go through the normal accounting stuff before submission.
----

Do you know why you changed it, Nigel? It looks more than a change of
ToI nomenclature.

	-Kenny

-- 
Kenneth R. Crudup  Sr. SW Engineer, Scott County Consulting, Los Angeles