Re: [Suspend2-users] Re: hdd spindown during suspend [repost…

Hi.

On Sunday 05 February 2006 02:44, swsusp2-eran@??? wrote:
> On 2006-02-04 14:51, Nigel Cunningham wrote:
> >>> 00:1f.2 IDE interface: Intel Corporation 82801FBM (ICH6M) SATA
> >
> > Thanks guys. The controller will be the issue. Is this with that SATA
> > patch people have been pointing at?
>
> Linus's git tree, and probably 2.6.16-rc?, have the offending code
> merged in this commit:
> http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdi
>ff;h=9b847548663ef1039dd49f0eb4463d001e596bc3
>
>
> The drivers/scsi/ata_piix.c driver uses libata's ata_device_suspend(),
> defined in drivers/scsi/libata-core.c:
>
>
> /**
> *    ata_device_suspend - prepare a device for suspend
> *
> *    Flush the cache on the drive, if appropriate, then issue a
> *    standbynow command.
> *
> */
> int ata_device_suspend(struct ata_port *ap, struct ata_device *dev)
> {
>     if (!ata_dev_present(dev))
>         return 0;
>     if (dev->class == ATA_DEV_ATA)
>         ata_flush_cache(ap, dev);
>
>     ata_standby_drive(ap, dev);
>     ap->flags |= ATA_FLAG_SUSPENDED;
>     return 0;
> }
>
>
> where
>
>
> static int ata_standby_drive(struct ata_port *ap, struct ata_device *dev)
> {
>     return ata_do_simple_cmd(ap, dev, ATA_CMD_STANDBYNOW1);
> }
>

Sorry for the slow response.

Could I get you to report this on LKML and/or open a bug on
bugzilla.kernel.org?

Regards,

Nigel